Fuzzy search for properties #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buwilliams
reviewed
Apr 23, 2021
| @@ -1,4 +1,5 @@ | |||
| import React from 'react' | |||
| import React, { useState } from 'react' | |||
| import Fuse from 'fuse.js' | |||
There was a problem hiding this comment.
I've used Fuse before, it's pretty great.
samwinslow
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Great experience improvement. +1 to what @buwilliams said — Fuse is quite powerful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add fuzzy search to the properties dropdown for ease of use. A specific thing I ran against was typing
utm campaignwhich didn't work as the actual key is$utm_campaign. Tested up to 10k props and it's fast.Checklist