ActionStep.url_contains can also be NULL #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a custom event.
timgl
approved these changes
Apr 2, 2020
yakkomajuri
pushed a commit
that referenced
this pull request
Oct 1, 2021
* try to run this package from within posthog * cat the log also here * keep only production deps * add database * delete benchmark tests * fix db urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #380
Hi, investigating #380 I see this error when trying to update an action step with the type "custom event":
Apparently "url_matching" is the only column in the table that should not be null. When first creating an action or editing an action with a different type (pageview, frontend element), url_matches is always set to something. However when saving a custom event action step, "url_matching" is cleared on the frontend and then the backend gives an error.
The fix was either to put a random value into url_matches when saving the custom event action step... or removing this null field and preventing an ugly hack on the frontend. I chose the latter :).