Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

445 trends time interval #504

Merged
merged 48 commits into from
Apr 9, 2020
Merged

445 trends time interval #504

merged 48 commits into from
Apr 9, 2020

Conversation

Tmunayyer
Copy link
Contributor

Changes

Issue: #445

  • Set intervals for volume graphs in the trends tab
  • Autocorrecting interval based on date range selection (sets hourly interval to daily if range get sets to last 90 days) due to performance on frontend

Checklist

  • Code reviewed
  • QA'd

@timgl timgl temporarily deployed to posthog-445-trends-time-yzzls9 April 8, 2020 14:45 Inactive
@timgl timgl temporarily deployed to posthog-445-trends-time-yzzls9 April 8, 2020 15:47 Inactive
@timgl timgl temporarily deployed to posthog-445-trends-time-yzzls9 April 8, 2020 15:55 Inactive
@timgl timgl temporarily deployed to posthog-445-trends-time-yzzls9 April 8, 2020 20:12 Inactive
@timgl
Copy link
Collaborator

timgl commented Apr 8, 2020

  • Clicking hourly -> today doesn't display anything
  • When clicking hourly and then clicking on a data point, it shows People for the whole day, not just the hour. Same with weekly or monthly, it'll only show data for one day. I'm in favour of creating a new ticket for this to fix as this PR is getting pretty big.

@timgl timgl temporarily deployed to posthog-445-trends-time-yzzls9 April 8, 2020 20:56 Inactive
@Tmunayyer
Copy link
Contributor Author

"Today, Hourly" is fixed now. The date range was technically 0 so the time_index wasn't able to create the hourly buckets. This is fixed by some additional logic in the date_from and date_to are equal.

Will create a new issue for the people issue

@timgl timgl temporarily deployed to posthog-445-trends-time-yzzls9 April 9, 2020 08:46 Inactive
@timgl timgl merged commit d83d1b3 into master Apr 9, 2020
@timgl timgl deleted the 445-trends-time-interval branch April 9, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants