Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #444 add filtering by dates in funnels #506

Merged
merged 1 commit into from Apr 9, 2020
Merged

Closes #444 add filtering by dates in funnels #506

merged 1 commit into from Apr 9, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Apr 8, 2020 •
edited

image

This also solves issues with the display of users below. That should now actually make sense/be useful

@mariusandra Would love a good CR, especially on the Kea bits.

@timgl timgl requested a review from mariusandra April 8, 2020 17:37
@timgl timgl temporarily deployed to posthog-444-filtering-b-x1zxu6 April 8, 2020 17:38 Inactive
@timgl timgl force-pushed the 444-filtering-by-dates-in-funnels branch from ec6967e to 3b331a3 Compare April 8, 2020 20:18
@timgl timgl temporarily deployed to posthog-444-filtering-b-x1zxu6 April 8, 2020 20:18 Inactive
@timgl timgl force-pushed the 444-filtering-by-dates-in-funnels branch from 3b331a3 to 203d63b Compare April 8, 2020 20:36
@timgl timgl temporarily deployed to posthog-444-filtering-b-x1zxu6 April 8, 2020 20:36 Inactive
@timgl timgl added this to In progress in Parity (Roadmap phase 1) Apr 8, 2020
@timgl timgl moved this from In progress to Review in progress in Parity (Roadmap phase 1) Apr 8, 2020
@timgl timgl self-assigned this Apr 8, 2020
mariusandra
mariusandra requested changes Apr 9, 2020
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback on the kea parts.

frontend/src/scenes/funnels/funnelLogic.js Outdated Show resolved Hide resolved
frontend/src/scenes/funnels/funnelLogic.js Outdated Show resolved Hide resolved
frontend/src/scenes/funnels/funnelLogic.js Outdated Show resolved Hide resolved
frontend/src/scenes/funnels/funnelLogic.js Outdated Show resolved Hide resolved
frontend/src/scenes/funnels/funnelLogic.js Outdated Show resolved Hide resolved
@timgl timgl force-pushed the 444-filtering-by-dates-in-funnels branch from 203d63b to 6ef0421 Compare April 9, 2020 09:25
@timgl timgl temporarily deployed to posthog-444-filtering-b-x1zxu6 April 9, 2020 09:25 Inactive
@timgl timgl force-pushed the 444-filtering-by-dates-in-funnels branch from 6ef0421 to ec376f6 Compare April 9, 2020 09:27
@timgl timgl temporarily deployed to posthog-444-filtering-b-x1zxu6 April 9, 2020 09:27 Inactive
@timgl timgl force-pushed the 444-filtering-by-dates-in-funnels branch from ec376f6 to 3d2f78e Compare April 9, 2020 09:30
@timgl timgl temporarily deployed to posthog-444-filtering-b-x1zxu6 April 9, 2020 09:31 Inactive
@timgl
Copy link
Collaborator Author

timgl commented Apr 9, 2020

@Tannergoods Would you mind QA'ing?

@Tannergoods
Copy link
Contributor

This looks great! Touched all things Funnels, makes user display better as noted above.

@timgl
Copy link
Collaborator Author

timgl commented Apr 9, 2020

@Tannergoods Thanks!

@timgl timgl merged commit 8f9f827 into master Apr 9, 2020
Parity (Roadmap phase 1) automation moved this from Review in progress to Done Apr 9, 2020
@timgl timgl deleted the 444-filtering-by-dates-in-funnels branch April 9, 2020 10:00
yakkomajuri pushed a commit that referenced this pull request Oct 1, 2021
@timgl
Upgrade AdmZip to 0.5.3 (#506)
eab4622
@sathishcyberintelsysnew sathishcyberintelsysnew mentioned this pull request Apr 7, 2023
Open
This was referenced Apr 14, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra requested changes

Assignees

@timgl timgl

Labels
None yet
Projects
No open projects
Parity (Roadmap phase 1)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timgl @Tannergoods @mariusandra