Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Excluding Events from Funnels #5104

Merged
merged 7 commits into from
Jul 15, 2021
Merged

Add Support for Excluding Events from Funnels #5104

merged 7 commits into from
Jul 15, 2021

Conversation

neilkakkar
Copy link
Collaborator

Changes

A Part of #5074

Exclusion for unordered-strict to come in a following PR. Separating big brain bits from the small brain bits.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@timgl timgl temporarily deployed to posthog-pr-5104 July 13, 2021 15:05 Inactive
@neilkakkar neilkakkar marked this pull request as ready for review July 14, 2021 12:38
@timgl timgl temporarily deployed to posthog-pr-5104 July 14, 2021 12:38 Inactive
@timgl timgl temporarily deployed to posthog-pr-5104 July 14, 2021 12:40 Inactive
@timgl timgl temporarily deployed to posthog-pr-5104 July 14, 2021 12:44 Inactive
@neilkakkar neilkakkar changed the title Exclusion Events Add Support for Excluding Events from Funnels Jul 14, 2021
@neilkakkar neilkakkar mentioned this pull request Jul 15, 2021
Merged
6 tasks
Twixes
Twixes approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me

@neilkakkar neilkakkar merged commit 8a1bd1c into master Jul 15, 2021
@neilkakkar neilkakkar deleted the exclusions branch July 15, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neilkakkar @Twixes @timgl