Fix Funnel Trends Persons with month/week granularity #5277

neilkakkar · 2021-07-22T10:04:11Z

Changes

resolve #5275

All querysets/queries filter by Organization, by Team, and by User
Django backend tests
Jest frontend tests
Cypress end-to-end tests
Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
New/changed UI is decent on smartphones (viewport width around 360px)

ee/clickhouse/queries/funnels/funnel_trends.py

ee/clickhouse/queries/funnels/test/test_funnel_trends.py

ee/clickhouse/queries/funnels/funnel_trends.py

macobo

LGTM other than the nit

resolve #5275

90e87ba

neilkakkar requested review from EDsCODE and macobo July 22, 2021 10:04

timgl temporarily deployed to posthog-pr-5277 July 22, 2021 10:05 Inactive

macobo reviewed Jul 22, 2021

View reviewed changes

ee/clickhouse/queries/funnels/funnel_trends.py Outdated Show resolved Hide resolved

macobo reviewed Jul 22, 2021

View reviewed changes

ee/clickhouse/queries/funnels/test/test_funnel_trends.py Show resolved Hide resolved

address comment

e3b887c

timgl temporarily deployed to posthog-pr-5277 July 22, 2021 10:19 Inactive

macobo reviewed Jul 22, 2021

View reviewed changes

ee/clickhouse/queries/funnels/funnel_trends.py Outdated Show resolved Hide resolved

rm unused piece

5f9d665

timgl temporarily deployed to posthog-pr-5277 July 22, 2021 11:01 Inactive

macobo approved these changes Jul 22, 2021

View reviewed changes

neilkakkar enabled auto-merge (squash) July 22, 2021 11:03

neilkakkar merged commit b8c946c into master Jul 22, 2021

neilkakkar deleted the trends-fix-persons branch July 22, 2021 11:49