Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Path Persons API endpoint #6070

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Introduce Path Persons API endpoint #6070

merged 3 commits into from
Sep 22, 2021

Conversation

neilkakkar
Copy link
Collaborator

Changes

This PR introduces the /api/person/path/ endpoint, which allows querying for users on Paths.

The request expects the same filter as given to Paths, plus two new parameters:

path_start_key and path_end_key. These determine the start and end point of Paths you want. Both of these are optional.

Not specifying them means "get me all users on this path query".

Only specifying path_start_key means "get me all users whose paths start at this key"
Only specifying path_end_key means "get me all users whose paths end at this key"

Specifying both means "get me all users whose path starts at start_key and ends at end_key."

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@timgl timgl temporarily deployed to posthog-pr-6070 September 22, 2021 11:18 Inactive
@timgl timgl temporarily deployed to posthog-pr-6070 September 22, 2021 11:22 Inactive
@timgl timgl temporarily deployed to posthog-pr-6070 September 22, 2021 15:43 Inactive
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@neilkakkar neilkakkar enabled auto-merge (squash) September 22, 2021 16:55
@neilkakkar neilkakkar merged commit cda9cfa into master Sep 22, 2021
@neilkakkar neilkakkar deleted the path_persons_api branch September 22, 2021 17:01
pauldambra pushed a commit that referenced this pull request Sep 23, 2021
* introduce path persons API endpoint

* docs in query class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants