Allow excluding wildcards in paths #6111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolodamico
reviewed
Sep 27, 2021
There was a problem hiding this comment.
Conceptually this makes sense to me, but I'm not the right person to review this, I'm not sure what the notation 2_/3 means, can you clarify? Maybe it's better just to wait for @EDsCODE
EDsCODE
reviewed
Sep 27, 2021
| "date_from": "2012-01-01", | ||
| "exclude_events": ["/bar/*/foo"], | ||
| "include_event_types": ["$pageview"], | ||
| "path_groupings": ["/bar/*/foo"], |
There was a problem hiding this comment.
maybe worth adding more tests cases such as excluding events that aren't grouped?
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh i meant if you specified exclusion groupings but didn't have the corresponding path grouping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Wildcards can now be used in exclude events filter
Checklist