added copy code to clipboard changes #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sac0 Hi, maybe I'm being silly but I can't see any of the code that does the copy to clipboard in this pull request. Did you maybe forget to commit it? |
|
Hi @timgl . I'm sorry to have messed up. Actually i had added the whole output from hilite.me in a single line. The linters split it to multiple lines. I also had to check moving to multiple lines didn't mess up with the whitespace. So i was checking if i have to commit the large file and forgot to commit it. I have also added the steps to regenerate it just in case the script has to be changed. |
|
This is awesome, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a copy code to clipboard feature and added code highlighting. This is for the Issue.
Couldn't use the copytoclipboard from inviteTeam as that had a textarea to select. This is a pre that has to be copied. Hence used a different approach.
This code adds a lengthy and also looks messy in utils.js which i felt should be comparatively clean and readable and that it was better of without this. So i create a component.
Please leave a comment on any changes required on this one. I'm just getting started on OSS contribution. I would love to incorporate the changes.
Checklist