Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved insight fixes 2 #6674

Merged
merged 19 commits into from
Oct 28, 2021
Merged

Saved insight fixes 2 #6674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a29baf1
insights buttons padding right fix
mariusandra Oct 26, 2021
5b521c4
add icon column
mariusandra Oct 26, 2021
e7ce255
fix all types
mariusandra Oct 26, 2021
4fd5619
fix select icons
mariusandra Oct 26, 2021
bd86431
improve display and empty states
mariusandra Oct 27, 2021
9658ded
searching for a number gives a direct result
mariusandra Oct 27, 2021
a575423
more debouncing time to throttle typing in the searchfield
mariusandra Oct 27, 2021
06923ee
2 columns > 960px, 3 columns > 1580px
mariusandra Oct 27, 2021
2d3cb6a
more height for card view
mariusandra Oct 27, 2021
c6eadee
split options column
mariusandra Oct 27, 2021
f1dc2e8
add person icon
mariusandra Oct 27, 2021
65209f3
added profile picture
mariusandra Oct 27, 2021
b338633
fix column sort
mariusandra Oct 27, 2021
333a52d
add min-width to funnels to make them readable on tiny dashboards
mariusandra Oct 27, 2021
e8e5d2a
add "trends" as default type
mariusandra Oct 28, 2021
bb8cc4e
stop screaming
mariusandra Oct 28, 2021
1a6ede4
Merge branch 'master' into saved-insight-fixes-2
mariusandra Oct 28, 2021
2bd77cc
fix api call
mariusandra Oct 28, 2021
e61fbda
Merge branch 'master' into saved-insight-fixes-2
mariusandra Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/scenes/funnels/FunnelBarGraph.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ $funnel_canvas_background: #fafafa;

.funnel-step {
width: 30%;
min-width: 200px;
display: flex;
flex-direction: column;

Expand Down
22 changes: 17 additions & 5 deletions frontend/src/scenes/insights/EmptyStates/EmptyStates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,15 +256,15 @@ export function FunnelInvalidExclusionFiltersEmptyState(): JSX.Element {

const SAVED_INSIGHTS_COPY = {
[`${SavedInsightsTabs.All}`]: {
title: 'There are no insights for this project',
title: 'There are no insights $CONDITION.',
description: 'Once you create an insight, it will show up here.',
},
[`${SavedInsightsTabs.Yours}`]: {
title: "You haven't created insights for this project",
title: "You haven't created insights $CONDITION.",
description: 'Once you create an insight, it will show up here.',
},
[`${SavedInsightsTabs.Favorites}`]: {
title: 'There are no favorited insights for this project',
title: 'There are no favorited insights $CONDITION.',
description: 'Once you favorite an insight, it will show up here.',
},
}
Expand All @@ -273,16 +273,28 @@ export function SavedInsightsEmptyState(): JSX.Element {
const { addGraph } = useActions(savedInsightsLogic)
const {
filters: { tab },
insights,
usingFilters,
} = useValues(savedInsightsLogic)

// show the search string that was used to make the results, not what it currently is
const searchString = insights.filters?.search || null
const { title, description } = SAVED_INSIGHTS_COPY[tab]

return (
<div className="saved-insight-empty-state">
<div className="insight-empty-state__wrapper">
<div className="illustration-main">
<IconTrendUp />
</div>
<h2 className="empty-state__title">{SAVED_INSIGHTS_COPY[tab].title}</h2>
<p className="empty-state__description">{SAVED_INSIGHTS_COPY[tab].description}</p>
<h2 className="empty-state__title">
{usingFilters
? searchString
? title.replace('$CONDITION', `matching "${searchString}"`)
: title.replace('$CONDITION', `matching these filters`)
: title.replace('$CONDITION', 'for this project')}
</h2>
<p className="empty-state__description">{description}</p>
{tab !== SavedInsightsTabs.Favorites && (
<Button
size="large"
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/insights/Insights.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ $funnel_canvas_background: #fafafa;

.insights-tab-actions {
margin-left: auto;
padding: 0 1rem;
padding-left: 1rem;
display: flex;
flex-wrap: nowrap;

Expand Down
32 changes: 32 additions & 0 deletions frontend/src/scenes/saved-insights/SavedInsights.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,19 @@
border: 1px solid $border;
border-radius: 4px;
padding: 8px;

.icon-column {
width: 32px;
padding-right: 0;
svg {
display: block;
}
}
.options-column {
width: 24px;
padding-left: 0;
padding-right: 10px;
}
}

.ant-tabs-nav-wrap {
Expand Down Expand Up @@ -180,3 +193,22 @@
line-height: 21px;
}
}

.insight-type-icon-dropdown {
vertical-align: middle;
}
.insight-type-icon-wrapper {
display: flex;
align-items: center;
.icon-container {
height: 22px;
width: 22px;
margin-right: 8px;
position: relative;
.icon-container-inner {
position: absolute;
top: -6px;
left: -5px;
}
}
}