Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #665 Allow editing of frontend elements on actions in app #670

Merged
merged 3 commits into from Apr 30, 2020
Merged

Closes #665 Allow editing of frontend elements on actions in app #670

merged 3 commits into from Apr 30, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Apr 27, 2020

Changes

  • Show href/text/selector/url under frontend element
  • If nothing is inputted, force use of toolbar to select something.

Checklist

  • All querysets/queries filter by Team
  • Code reviewed
  • QA'd

@timgl timgl requested a review from EDsCODE April 27, 2020 16:37
@timgl timgl temporarily deployed to posthog-allow-editing-f-ynsbzu April 27, 2020 16:38 Inactive
EDsCODE
EDsCODE reviewed Apr 28, 2020
View reviewed changes
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on initial load and display. However, if you are viewing the frontend element, click to a pageview tab and then click back to frontend element, the fields will be cleared. I'm assuming it should remain filled

@timgl
Copy link
Collaborator Author

timgl commented Apr 28, 2020

Fixed, thanks!

@timgl timgl temporarily deployed to posthog-allow-editing-f-ynsbzu April 28, 2020 14:34 Inactive
@EDsCODE
Copy link
Member

EDsCODE commented Apr 29, 2020

Still getting the behavior described above

@timgl timgl temporarily deployed to posthog-allow-editing-f-ynsbzu April 30, 2020 09:51 Inactive
@timgl
Copy link
Collaborator Author

timgl commented Apr 30, 2020

@EDsCODE The only field that got cleared for me was the URL field, which I've now fixed. Are the other ones being cleared for you too?

EDsCODE
EDsCODE approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works after latest commit!

@timgl timgl merged commit 964d97e into master Apr 30, 2020
@timgl timgl deleted the allow-editing-frontend-element-in-posthog branch April 30, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @EDsCODE