-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#477 filter per entity #671
Conversation
@timgl How do you think we should start displaying the entity specific information (DAU, properties)? The graphs and tables can get confusing if only the action/event is noted. The dau is easy as we can just add an extra bit to the labels, but the properties would be a lot of text to try to push into the label |
@EDsCODE Reviewed, functionally works great! Re: how to display this in the label, I think the key is actually not that important in this scenario.
Should be displayed as
|
Don't want this to overextend so I added the symbols to all property filters and did an abbreviated property addition to the label. One concern is that adding a bunch of prop filters could result in a really long label. I opted for this anyway because for the moment I think it's sufficient. Can add a more comprehensive legend as needed. lmk! |
oof I checked out the problem because it seemed strange that any of my changes would affect how the filters are being processed and realized it was a bug on master too. Changed the null to 'exact' so the backend will pick it up directly in parsing and so we have consistent value for equality filter |
Ready for a look again! The failing test is the common one regarding |
Addresses #477
Changes
showMaths
property_filter_events
TODO:
Checklist