Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insight urls #6918

Closed
wants to merge 4 commits into from
Closed

Fix insight urls #6918

wants to merge 4 commits into from

Conversation

mariusandra
Copy link
Collaborator

Changes

  • Move all the previous URLs to this structure:
    • /insights - this used to be called "saved insights"
    • /insights/new - creates a new insight and redirects to it directly
    • /insights/123
    • /insights/123/edit
  • Ths PR will probably never get merged, as it got too big. I'm keeping it up as a draft to have a reference I can look at when I make more targeted PRs.

How did you test this code?

  • Never did, just kept writing code until it tested me.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@Twixes
Copy link
Collaborator

Twixes commented Nov 19, 2021

Closing in favor of #7201

@Twixes Twixes closed this Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants