Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breakdown by cohort search bug #785

Merged
merged 1 commit into from
May 15, 2020
Merged

Fix breakdown by cohort search bug #785

merged 1 commit into from
May 15, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented May 15, 2020

Fixes #756 and #778

Changes

  • add null condition

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)

@timgl timgl temporarily deployed to posthog-cohort-search-b-6r6ite May 15, 2020 18:06 Inactive
@EDsCODE EDsCODE changed the title add null condition Fix breakdown by cohort search bug May 15, 2020
@EDsCODE EDsCODE marked this pull request as ready for review May 15, 2020 18:12
@EDsCODE EDsCODE requested a review from timgl May 15, 2020 18:12
@EDsCODE EDsCODE linked an issue May 15, 2020 that may be closed by this pull request
Filtering trends by cohorts leads to blank screen for certain cohorts #778
Closed
@timgl
Copy link
Collaborator

timgl commented May 15, 2020

I can't reproduce locally (weirdly enough?) so let's merge and get it live

@timgl timgl merged commit e98d534 into master May 15, 2020
@timgl timgl deleted the cohort-search-bug branch May 15, 2020 18:27
@timgl
Copy link
Collaborator

timgl commented May 15, 2020

Yep looks good on app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@EDsCODE @timgl