Fix recording page refresh loop #8685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkim205
approved these changes
Feb 17, 2022
| @@ -161,7 +161,7 @@ export function Person({ _: urlId }: { _?: string } = {}): JSX.Element | null { | |||
| key={PersonsTabType.SESSION_RECORDINGS} | |||
| > | |||
| <SessionRecordingsTable | |||
| key={person.distinct_ids.join('__')} // force refresh if distinct_ids change | |||
| key={person.uuid} // force refresh if user changes | |||
There was a problem hiding this comment.
Nice, do you think it's worth making the fix in the EventsTable above as well?
EDsCODE
added a commit
that referenced
this pull request
Feb 18, 2022
* master: hobby: Wait for ClickHouse and for Postgres before starting (#8686) Part 2: Deprecate old tags and upgrade to new tags Backend (#8529) Remove flake8-commas (#8695) Update Breakdown props to use filter groups (#8679) Automatically switch to the right project if possible (#8681) Super Lazy VMs (#8609) .github/workflows/ci-backend.yml: fix flake8 config (#8676) Fix recording page refresh loop (#8685) Instance status configuration (#8096)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The recording page could get in a refresh loop on the persons page. It was hard for me to figure out exactly what's causing it, but if I make a distinct_id have URL encoded params (e.g. an email), I can repro it sometimes...
Pretty sure this is what this user is hitting.
How did you test this code?
Got the bug to repro sometimes (using
identify(user.email)), and then I made this change. Refreshed the page a ton of times. Couldn't get it to repro again.