Speed up events endpoint #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDsCODE
reviewed
Jun 2, 2020
| return response.Response({ | ||
| 'next': len(events) > 100, | ||
| 'next': next_url, |
There was a problem hiding this comment.
Did you mean to change how eventtablelogic works? This URL looks good but the table logic doesn't use it yet because before it was just a boolean. Either way it's good to go
There was a problem hiding this comment.
It wasn't part of this ticket so I'll get this in and come back to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This massively speeds up large instances:
Original:
PR:
The difference will be even more pronounced on bigger instances.
Checklist