Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compare sessions distribution bug #980

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Fix compare sessions distribution bug #980

merged 2 commits into from
Jun 15, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jun 11, 2020 •
edited
Loading

Changes

  • temporary patch for bug where comparing trend session distribution was erroring

Followup should be #979 to make sessions on the trends page have better coverage

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@EDsCODE EDsCODE requested a review from timgl June 11, 2020 00:57
@timgl timgl temporarily deployed to posthog-compare-session-fziitb June 11, 2020 00:58 Inactive
@timgl
Copy link
Collaborator

timgl commented Jun 11, 2020 •
edited
Loading

Would be good to add/modify a test here to make sure it doesn't happen again

@timgl timgl temporarily deployed to posthog-compare-session-fziitb June 12, 2020 13:08 Inactive
@timgl timgl merged commit a96ea4a into master Jun 15, 2020
@timgl timgl deleted the compare_sessions_dist_bug branch June 15, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EDsCODE @timgl