make check on current master

[wolfgangwalther]

When I run make check on the current master branch, I get this diff.

The changes to stack.yaml.lock appear whenever I run make test.

Seems like the whitespace stuff for imports only appeared after I updated stylish-haskell. Right now, I can't use make style because the resulting diff is just too annoying.

Is this something where I have to change my config somehow? Or should we just merge those changes?

[wolfgangwalther]

The CI failures don't make any sense to me. I guess they are the result of the changes to stack.yaml.lock?

[steve-chavez]

@wolfgangwalther What's your stylish-haskell version? I have:

> stylish-haskell --version
stylish-haskell 0.11.0.3

The CI failures don't make any sense to me.

Weird.. I'm not sure either. It's like the styler messed the files somehow.

[wolfgangwalther]

@wolfgangwalther What's your stylish-haskell version? I have:

0.12.0.0

Weird.. I'm not sure either. It's like the styler messed the files somehow.

Maybe you can try checking out this branch and then running make style. Do you get the same error?

[steve-chavez]

make style

Unfortunately that doesn't work for me(error: attribute 'ghc883' missing). But that's because I've been using the nix workflow and haven't touched stack for a while.

0.12.0.0

Perhaps you could try downgrading to 11.0.3? 12 looks a bit new and there are already new releases with fixes: https://github.com/jaspervdj/stylish-haskell/releases

[wolfgangwalther]

Perhaps you could try downgrading to 11.0.3? 12 looks a bit new and there are already new releases with fixes: https://github.com/jaspervdj/stylish-haskell/releases

Ah, thanks for the pointer. I'm running Arch Linux, so it would probably be more like... upgrading instead. I flagged the package out of date for now and will see what happens, when I update.

I removed the make style commit from this PR for now to see what the make test (change of stack.yaml.lock) will result in with the CI.

[wolfgangwalther]

Since this passes all tests - any objection to merging this? This would make my life with stack a bit easier.