Rename config settings with fallback aliases #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfgangwalther
force-pushed
the
config-aliases
branch
2 times, most recently
from
e544b1b
to
7730c4d
Compare
wolfgangwalther
changed the title
wolfgangwalther
force-pushed
the
config-aliases
branch
from
7730c4d
to
e954541
Compare
|
LGTM! Just tried omitting Which is great! I also like the new |
steve-chavez
approved these changes
Dec 6, 2020
* secret-is-base64 -> jwt-secret-is-base64 * role-claim-key -> jwt-role-claim-key * max-rows -> db-max-rows * pre-request -> db-pre-request * root-spec -> db-root-spec * db-schema -> db-schemas This is not a breaking change, because aliases are added as well. refactor: sorted all config keys alphabetically where applicable
wolfgangwalther
force-pushed
the
config-aliases
branch
from
e954541
to
5aa62b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1668 (comment) this changes names for some of the config options:
I also changed db-schema to db-schemas, because that's how it was used internally. I guess this was changed once multi schema support was included.
All of the old names are added as aliases, so there is no breaking changes - existing configs continue to work.
The first commit ("changed: ...") is the renaming of config options (trivial) + a lot of sorting, so that config options with the same prefix are now nicely grouped everywhere. Everywhere except the
--helpoutput that is, because this follows a slightly different logic, so I did not touch that again. This 3rd commit creates a big diff because of all the sorting, but just compiling and running all the tests should give enough confidence. This will not need a deep review.The second commit ("added: ...") is the code for the aliases. This is new code and should be reviewed properly.