Add Function and Tests for Radius function #107

CedricMoreau · 2019-10-09T12:12:18Z

No description provided.

PowerArubaSW/Public/Ipadress.ps1

PowerArubaSW/Public/RADIUS.ps1

Tests/integration/Radius.Tests.ps1

alagoutte · 2019-10-10T07:58:06Z

Tests/integration/Radius.Tests.ps1

+        Remove-ArubaSWRadius -id 1
+    }
+
+    It "Add-ArubaSWRadius ports" {


Add RADIUS with change ports... (same for other after)

Please rename title of test !

alagoutte · 2019-10-10T07:58:55Z

Tests/integration/Radius.Tests.ps1

+        Add-ArubaSWRadius -address 192.0.2.1 -shared_secret powerarubasw -is_dyn_autorization_enabled -time_window_type TW_PLUS_OR_MINUS_TIME_WINDOW -time_window 0 -authentication_port 1800 -accounting_port 1801
+    }
+
+    It "Set-ArubaSWRadius mandatory parameters" {


Change Mandatory Parametre...

alagoutte

Do you have also check the indent ? (using Visual Code Formater ?)

PowerArubaSW/Public/Ipadress.ps1

alagoutte · 2019-10-10T14:49:23Z

PowerArubaSW/Public/RADIUS.ps1

+        This function give you all the informations about the radius servers parameters configured on the switch.
+
+        .EXAMPLE
+        Get-ArubaSWRadius -id 2


forget to update .EXEMPLE

alagoutte · 2019-10-10T14:49:55Z

PowerArubaSW/Public/RADIUS.ps1

+
+        $run = ($response | ConvertFrom-Json).radius_server_element
+
+        if ( $address ) {


kept always id (and address)

PowerArubaSW/Public/RADIUS.ps1

alagoutte · 2019-10-10T14:51:41Z

PowerArubaSW/Public/RADIUS.ps1

+    #>
+
+    Param(
+        [Parameter (Mandatory = $true)]


Please pipeline !

alagoutte · 2019-10-10T14:52:28Z

PowerArubaSW/Public/RADIUS.ps1

+
+        $conf = New-Object -TypeName PSObject
+
+        $ip = New-Object -TypeName PSObject


move in if ($PsBoundParameters.ContainsKey('address'))

alagoutte · 2019-10-10T14:53:28Z

Tests/integration/Radius.Tests.ps1

+        Remove-ArubaSWRadius -id 1
+    }
+
+    It "Add-ArubaSWRadius ports" {


Please rename title of test !

alagoutte · 2019-10-10T14:55:14Z

Tests/integration/Radius.Tests.ps1

+    }
+
+    AfterEach {
+        Remove-ArubaSWRadius -id $radius.radius_server_id


use Get-ArubaSWRADIUS before ?

alagoutte · 2019-10-10T14:55:34Z

Tests/integration/Radius.Tests.ps1

+    }
+
+    AfterEach {
+        Remove-ArubaSWRadius -id $id_server.radius_server_id


alagoutte · 2019-10-11T15:11:08Z

PowerArubaSW/Public/RADIUS.ps1

+
+        $run = ($response | ConvertFrom-Json).radius_server_element
+
+        if ( $address -And !$id ) {


Use ParameterSet (when you specific parameter)

alagoutte

Always some issue no yet fixed

alagoutte

Need to check pipeline stuff and minor stuff

PowerArubaSW/Public/Ipadress.ps1

alagoutte · 2019-10-14T19:10:05Z

PowerArubaSW/Public/RADIUS.ps1

+
+    Param(
+        [Parameter (Mandatory = $false)]
+        [string]$address,


[string] -> ipaddress ?

PowerArubaSW/Public/RADIUS.ps1

alagoutte · 2019-10-14T19:11:04Z

PowerArubaSW/Public/RADIUS.ps1

+        Set-ArubaSWRadius -id 1 -address 192.0.2.1 -shared_secret powerarubasw
+        Change parameters for a radius server
+        .EXAMPLE
+        Set-ArubaSWRadius -id 2 -address 192.0.2.2 -shared_secret powerarubasw -authentication_port 1812 -accounting_port 1813 -is_dyn_autorization_enabled -time_window_type TW_PLUS_OR_MINUS_TIME_WINDOW -time_window 0 -is_oobm


Not yet fixed

alagoutte · 2019-10-14T19:11:40Z

PowerArubaSW/Public/RADIUS.ps1

+    Param(
+        [Parameter (Mandatory = $false)]
+        [ValidateRange (1, 15)]
+        [int]$id,


add Pipeline too here

alagoutte · 2019-10-14T19:12:17Z

PowerArubaSW/Public/RADIUS.ps1

+    #>
+
+    Param(
+        [Parameter (Mandatory = $true, ValueFromPipeline = $true)]


add example with pipeline (do you have ? working ?)

alagoutte · 2019-10-14T19:12:47Z

PowerArubaSW/Public/RADIUS.ps1

+        [ValidateRange (1, 15)]
+        [int]$id,
+        [Parameter (Mandatory = $false)]
+        [string]$address,


alagoutte · 2019-10-14T19:13:09Z

Tests/integration/Radius.Tests.ps1

+        Add-ArubaSWRadius -address 192.0.2.1 -shared_secret powerarubasw -time_window_type TW_PLUS_OR_MINUS_TIME_WINDOW -time_window 0
+        $radius = Get-ArubaSWRadius -address 192.0.2.1
+        $radius.time_window_type | Should be "TW_PLUS_OR_MINUS_TIME_WINDOW"
+        $radius.time_window | Should be "0"


What the value by default ?

alagoutte · 2019-10-14T19:13:29Z

Tests/integration/Radius.Tests.ps1

+        Add-ArubaSWRadius -address 192.0.2.1 -shared_secret powerarubasw -authentication_port 1800 -accounting_port 1801 -time_window_type TW_PLUS_OR_MINUS_TIME_WINDOW -time_window 0 -is_dyn_authorization_enabled
+    }
+
+    It "Check change on shared secret" {


Add check also with pipeline

alagoutte · 2019-10-14T19:13:49Z

Tests/integration/Radius.Tests.ps1

+}
+
+Describe  "Remove-ArubaSWRadius" {
+    It "Remove ArubaSWRadius server" {


same add also example with pipeline

…dd filter with Ip address instead of ID, etc ...

Wrong parameter for address and missing for is_dyn_aut....

and add example with id parameter

add example using pipeline

alagoutte requested changes Oct 10, 2019

View reviewed changes

alagoutte reviewed Oct 11, 2019

View reviewed changes

alagoutte requested changes Oct 11, 2019

View reviewed changes

alagoutte requested changes Oct 14, 2019

View reviewed changes

alagoutte added this to the v0.9.0 milestone Nov 2, 2019

alagoutte force-pushed the RADIUS_Function branch from 1870ec1 to 4a630ba Compare December 27, 2019 18:21

Cédric Moreau and others added 13 commits December 27, 2019 22:16

Add Function and Tests for Radius function

5cc9d98

Fix after review : add blank line, add noconfirm option for remove, a…

50963b4

…dd filter with Ip address instead of ID, etc ...

Fix after review

4f8f9e5

Fix tests

a89696b

Fix remove function to remove with address too

6f33f27

Add Pipeline use

cf4b3ac

RADIUS: fix indent (using Visual Code Formatter)

1768d1a

RADIUS: Fix Add-ArubaSWRadius example

38af501

Wrong parameter for address and missing for is_dyn_aut....

RADIUS(get): fix typo address => ipaddress

334bbf6

RADIUS: Use ParameterSetName for Get-(ArubaSW)Radius

e69a5fa

and add example with id parameter

RADIUS: Set-ArubaSWRadius remove debug...

76895d5

Set-ArubaSWRadius: Fix example and add example using pipeline

3b472cd

RADIUS: Fix example for Remove-ArubaSWRadius

6b939b8

add example using pipeline

alagoutte force-pushed the RADIUS_Function branch from 2f9a664 to 6b939b8 Compare December 27, 2019 21:17

alagoutte added 9 commits December 27, 2019 22:21

RADIUS(Tests): Fix indent

011b6bc

RADIUS(Tests): -address -> ipaddress

da8b730

RADIUS(tests): remove -(ip)address rom Set-ArubaSWRadius

044e431

RADIUS: Use ipaddress type for ipaddress Paramater

cc5b090

RADIUS(Server): ipaddres => address

f71e25b

RADIUS(Server): Radius => RADIUS

11e60f4

RADIUS(Server): Rename *-SWRadius to *-SWRadiusServer

09d5de4

RADIUS(Server): better Describe for test

c6b5b07

RADIUS(Server): Add pipeline test too

608a557

RADIUS(Server): Add BeforeAll for Remove

99932de

alagoutte merged commit cfcbd7c into PowerAruba:master Jan 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Function and Tests for Radius function #107

Add Function and Tests for Radius function #107

CedricMoreau commented Oct 9, 2019

alagoutte Oct 10, 2019

alagoutte Oct 10, 2019

alagoutte Oct 10, 2019

alagoutte left a comment

alagoutte Oct 10, 2019

alagoutte Oct 10, 2019

alagoutte Oct 10, 2019

alagoutte Oct 10, 2019

alagoutte Oct 10, 2019

alagoutte Oct 10, 2019

alagoutte Oct 10, 2019

alagoutte Oct 11, 2019 •

edited

Loading

alagoutte left a comment

alagoutte left a comment

alagoutte Oct 14, 2019

alagoutte Oct 14, 2019

alagoutte Oct 14, 2019

alagoutte Oct 14, 2019

alagoutte Oct 14, 2019

alagoutte Oct 14, 2019

alagoutte Oct 14, 2019

alagoutte Oct 14, 2019


		$run = ($response \| ConvertFrom-Json).radius_server_element

		if ( $address ) {


		$conf = New-Object -TypeName PSObject

		$ip = New-Object -TypeName PSObject


		$run = ($response \| ConvertFrom-Json).radius_server_element

		if ( $address -And !$id ) {

Add Function and Tests for Radius function #107

Add Function and Tests for Radius function #107

Conversation

CedricMoreau commented Oct 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alagoutte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alagoutte Oct 11, 2019 • edited Loading

Choose a reason for hiding this comment

alagoutte left a comment

Choose a reason for hiding this comment

alagoutte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alagoutte Oct 11, 2019 •

edited

Loading