Setting secpoll PACKAGEVERSION is broken

[zeha]

The previously supported way of doing

CXXFLAGS += -DPACKAGEVERSION='"$(version)"'

no longer works and fails with:

secpoll-auth.cc: In function 'void doSecPoll(bool)':
<command-line>:0:16: error: invalid operands of types 'const char [6]' and 'const char [26]' to binary 'operator+'
secpoll-auth.cc:127:27: note: in expansion of macro 'PACKAGEVERSION'
   string query = "auth-" +PACKAGEVERSION +".security-status."+::arg()["security-poll-suffix"];
                           ^
<command-line>:0:16: error: invalid operands of types 'const char [48]' and 'const char [26]' to binary 'operator+'
secpoll-auth.cc:154:76: note: in expansion of macro 'PACKAGEVERSION'
     L<<Logger::Warning<<"Could not retrieve security status update for '" +PACKAGEVERSION+ "' on '"+query+"', RCODE = "<< RCode::to_s(res)<<endl;
                                                                            ^

[Habbie]

This was broken in 77b9f5f. Perhaps we just need to string(PACKAGEVERSION).

[Habbie]

As @zeha points out on IRC, this should be a configure flag.