pdnsutil set-meta clobbers multi-valued domainmetadata

[jpmens]

• Program: Authoritative
• Issue type: Bug report

Short description

pdnsutil set-meta overwrites existing multi-valued settings in the domainmetadata table.

Environment

• Operating system: CentOS
• Software version: auth master
• Software source: PowerDNS repo

Steps to reproduce

$ pdnsutil create-zone a.aa
Creating empty zone 'a.aa'

$ pdnsutil set-meta a.aa ALLOW-AXFR-FROM 1.1.1.1/32
Set 'a.aa' meta ALLOW-AXFR-FROM = 1.1.1.1/32

$ pdnsutil set-meta a.aa ALLOW-AXFR-FROM 2.2.2.2/32
Set 'a.aa' meta ALLOW-AXFR-FROM = 2.2.2.2/32

$ sqlite3 powerdns.sqlite
sqlite> select * from domainmetadata;
6|3|ALLOW-AXFR-FROM|2.2.2.2/32

Expected behaviour

I expected the ALLOW-AXFR-FROM to be added to the table (INSERT).

Usecase

Use pdnsutil set-meta in a script to add settings to table in a controlled manner (instead of using naked SQL INSERT statements.

Description

The utility should, on multivalued settings, not overwrite existing ones or it should, at the very least, refuse operation informing user that it cannot write a setting because settings of same kind exist. Overwriting (and thereby destroying) data cannot be right!

[pieterlexis]

pdnsutil --help does say:

set-meta ZONE KIND [VALUE] [VALUE] Set zone metadata, optionally providing a value. *No* value clears meta
                                   Note - this will replace all metadata records of KIND!

But I think a 'add-metadata' might be not a bad idea

[jpmens]

The documentation doesn't say

set-meta ZONE ATTRIBUTE [VALUE]
    Set domainmetadata ATTRIBUTE for ZONE to VALUE. An empty value clears it.

and unfortunately, a

pdnsutil --help | grep set-meta

to find the synopsis for a subcommand I know exists doesn't either.... That's how it happened.

[Habbie]

pdnsutil --help | grep set-meta

grep -3 does the trick though..