Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Change spoof-nearmiss-max default to 1 #9845

Closed
mnordhoff opened this issue Dec 9, 2020 · 0 comments · Fixed by #10077
Closed

rec: Change spoof-nearmiss-max default to 1 #9845

mnordhoff opened this issue Dec 9, 2020 · 0 comments · Fixed by #10077

Comments

@mnordhoff
Copy link
Contributor

  • Program: Recursor
  • Issue type: Feature request

Short description

The spoof-nearmiss-max setting defaults to 20. In light of the SAD DNS attack bringing attention to this issue, it might be nice to change it to 1 (and perhaps even hardcode it in a later release).

I'm not sure if anyone remembers why 20 was chosen (in like 2006).

The question is if there are any downsides to changing it. Getting some large resolvers to experiment first might help answer that.

With the changes in #9744, I believe the design now matches Knot Resolver, which also uses 1 (and hardcodes it, I think).

From a coolness and marketing perspective, using Knot's analysis, using 1 totally mitigates the SAD DNS attack, while using 20 almost totally mitigates the attack, which doesn't sound as good.

Usecase

SAD DNS attack mitigation and consistency with Knot Resolver.

@omoerbeek omoerbeek added this to the rec-4.5.0 milestone Dec 10, 2020
omoerbeek added a commit to omoerbeek/pdns that referenced this issue Feb 10, 2021
chbruyand pushed a commit to chbruyand/pdns that referenced this issue Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants