Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdnsutil: Warn on CNAME targets for NS, MX and SRV #10087

Merged
merged 1 commit into from
Feb 17, 2021
Merged

pdnsutil: Warn on CNAME targets for NS, MX and SRV #10087

merged 1 commit into from
Feb 17, 2021

Conversation

pieterlexis
Copy link
Contributor

Short description

Fixes #10085

This only warns, even though having this is an RFC violation. Moderns resolvers and clients should be able to handle this situation just fine.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis pieterlexis added this to the auth-4.5.0 milestone Feb 16, 2021
Habbie
Habbie requested changes Feb 16, 2021
View reviewed changes
pdns/pdnsutil.cc Outdated Show resolved Hide resolved
@Habbie Habbie merged commit e746c97 into PowerDNS:master Feb 17, 2021
@pieterlexis pieterlexis deleted the check-MX-to-CNAME branch February 17, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Habbie Habbie Habbie approved these changes

Assignees
No one assigned
Labels
auth enhancement
Projects
None yet
Milestone
auth-4.5.0
Development

Successfully merging this pull request may close these issues.

pdnsutil check-zone doesn’t complain about MX pointing to CNAME record
2 participants
@pieterlexis @Habbie