Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Improve TCP connection reuse, add metrics #10156

Merged
merged 5 commits into from Mar 19, 2021

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Mar 9, 2021

Short description

This PR:

  • adds metrics about TCP connection reuse (total number of connections opened and reused per backend) ;
  • adds a new command to dump the states of TCP connections (incoming and outgoing) for debugging purposes ;
  • reuses the most recently used connection first, and for connections that have not been used in the last second checks whether it has been closed in the meantime. Detecting such a closed connection earlier make it possible to reuse another queued connection right away ;
  • provides better messages (only seen at verbose level) when a TLS connection has been closed by the other end.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne merged commit 50cd3b1 into PowerDNS:master Mar 19, 2021
@rgacogne rgacogne deleted the ddist-conn-reuse branch March 19, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant