Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Fix missing locks in DNSCrypt certificates management #10346

Merged
merged 1 commit into from
May 3, 2021
Merged

dnsdist: Fix missing locks in DNSCrypt certificates management #10346

merged 1 commit into from
May 3, 2021

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented May 3, 2021

Short description

In theory these functions should already be protected by the Lua lock but better safe than sorry.
Found while working on the migration to LockGuarded.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne
dnsdist: Fix missing locks in DNSCrypt certificates management
5a9cff1 
In theory these functions should already be protected by the Lua
lock but better safe than sorry.
Found while working on the migration to LockGuarded.
@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone May 3, 2021
@rgacogne rgacogne merged commit b65affc into PowerDNS:master May 3, 2021
@rgacogne rgacogne deleted the ddist-dnscrypt-locks branch May 3, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek approved these changes

@chbruyand chbruyand Awaiting requested review from chbruyand

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rgacogne @omoerbeek