rec: If new data is auth and existing data is not, replace even if cache locking is active #12027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking is active Followup to PowerDNS#11958
rgacogne
approved these changes
Sep 27, 2022
rgacogne
requested changes
Sep 27, 2022
Co-authored-by: Remi Gacogne <github@coredump.fr>
rgacogne
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #11958
Current code gives the right answer (the authoritative records) to the client but does not replace the unauthoritative record set in the cache by the authoritative one. That's a bit too strict interpretation of the locking feature.
Short description
Checklist
I have: