rec: Backport 12125 to rec 4.8.x: handle ixfr connect and transfer timeouts #12161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One complicating factor is that this is shared code, but auth and rec do not agree on the definiton of the timeout value: auth states it is a maximum idle time, while rec state it is the total xfr time. While both apporaches make sense and in the end we would like to enforce both, we now go for a more simple solution that respects auth or rec behaviour based on a flag. (cherry picked from commit fee334a)
Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com> (cherry picked from commit 240460d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Backport of #12125
Checklist
I have: