Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Add bindings for the current and query times in DQ/DR #12402

Merged
merged 1 commit into from
Jan 11, 2023
Merged

dnsdist: Add bindings for the current and query times in DQ/DR #12402

merged 1 commit into from
Jan 11, 2023

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jan 9, 2023

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Jan 9, 2023
@rgacogne
Copy link
Member Author

@chbruyand I pushed a new version, based on your very good remarks earlier :)

chbruyand
chbruyand approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rgacogne rgacogne merged commit 9c05895 into PowerDNS:master Jan 11, 2023
@rgacogne rgacogne deleted the ddist-dq-time branch January 11, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rgacogne @chbruyand