Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ixfrdist: add NOTIFY receive support #13322

Merged
merged 7 commits into from Oct 20, 2023
Merged

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Oct 3, 2023

Short description

part of #6994

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

pdns/ixfrdist-stats.hh Outdated Show resolved Hide resolved
@Habbie Habbie force-pushed the ixfrdist-notify-in branch 2 times, most recently from 004da34 to c413775 Compare October 9, 2023 18:09
@coveralls
Copy link

coveralls commented Oct 9, 2023

Pull Request Test Coverage Report for Build 6576469821

  • 101 of 146 (69.18%) changed or added relevant lines in 3 files are covered.
  • 196 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.09%) to 57.406%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/ixfrdist-stats.cc 8 10 80.0%
pdns/ixfrdist-stats.hh 0 3 0.0%
pdns/ixfrdist.cc 93 133 69.92%
Files with Coverage Reduction New Missed Lines %
pdns/misc.cc 2 62.39%
pdns/recursordist/rec-tcpout.cc 4 0.0%
pdns/recursordist/rec-zonetocache.cc 4 50.1%
pdns/ixfrdist.cc 5 58.68%
pdns/tcounters.hh 5 75.0%
pdns/mtasker.cc 6 67.02%
pdns/recursordist/rec_channel.cc 8 65.88%
pdns/recursordist/taskqueue.hh 9 42.86%
pdns/recursordist/recursor_cache.cc 10 76.37%
pdns/recursordist/rec-carbon.cc 12 0.0%
Totals Coverage Status
Change from base Build 6574953728: -0.09%
Covered Lines: 105256
Relevant Lines: 152765

💛 - Coveralls

@Habbie
Copy link
Member Author

Habbie commented Oct 19, 2023

made clang-tidy happy

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few remaining error messages, one suggestion.

pdns/ixfrdist.cc Outdated Show resolved Hide resolved
pdns/ixfrdist.cc Show resolved Hide resolved
@Habbie
Copy link
Member Author

Habbie commented Oct 19, 2023

Thanks Rémi, I added two commits

@rgacogne rgacogne self-requested a review October 20, 2023 06:56
pdns/ixfrdist.cc Show resolved Hide resolved
pdns/ixfrdist.cc Show resolved Hide resolved
@Habbie Habbie merged commit 42240b1 into PowerDNS:master Oct 20, 2023
74 checks passed
@Habbie Habbie deleted the ixfrdist-notify-in branch October 20, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants