New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ixfrdist: add NOTIFY receive support #13322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Habbie
force-pushed
the
ixfrdist-notify-in
branch
from
October 3, 2023 13:11
92872f7
to
2a020da
Compare
rgacogne
reviewed
Oct 3, 2023
Habbie
force-pushed
the
ixfrdist-notify-in
branch
2 times, most recently
from
October 9, 2023 18:09
004da34
to
c413775
Compare
Pull Request Test Coverage Report for Build 6576469821
💛 - Coveralls |
Habbie
force-pushed
the
ixfrdist-notify-in
branch
from
October 19, 2023 10:24
c413775
to
c8166ef
Compare
Habbie
force-pushed
the
ixfrdist-notify-in
branch
2 times, most recently
from
October 19, 2023 12:56
23ae609
to
0f2410d
Compare
Habbie
force-pushed
the
ixfrdist-notify-in
branch
from
October 19, 2023 13:14
0f2410d
to
612dfea
Compare
made clang-tidy happy |
rgacogne
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few remaining error messages, one suggestion.
Thanks Rémi, I added two commits |
rgacogne
reviewed
Oct 20, 2023
rgacogne
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
part of #6994
Checklist
I have: