Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: add a configurable delay for notifications #13649

Merged
merged 4 commits into from Jan 18, 2024

Conversation

chbruyand
Copy link
Member

@chbruyand chbruyand commented Dec 18, 2023

Short description

Adds a configurable delay-notifications parameter to delay notifications.

Fix #12785

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Dec 18, 2023

Pull Request Test Coverage Report for Build 7573561075

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 57.709%

Totals Coverage Status
Change from base Build 7571071755: 1.0%
Covered Lines: 107828
Relevant Lines: 155506

💛 - Coveralls

@Habbie Habbie added this to the auth-4.9.0-alpha1 milestone Dec 18, 2023
@Habbie Habbie modified the milestones: auth-4.9.0-alpha1, auth-4.9.0-alpha2 Jan 11, 2024
@Habbie Habbie self-requested a review January 18, 2024 12:59
Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I wonder if pdns_control notify should be undelayed, but we can also wait and see what users think. So, approved.

@Habbie
Copy link
Member

Habbie commented Jan 18, 2024

If you feel there is any work left, I'll wait, but otherwise, please hit Ready for review (and you might as well just merge then).

@Habbie
Copy link
Member

Habbie commented Jan 18, 2024

If you feel there is any work left, I'll wait, but otherwise, please hit Ready for review (and you might as well just merge then).

Oh, I just realised it doesn't have docs yet!

Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, really approved now :)

@chbruyand chbruyand marked this pull request as ready for review January 18, 2024 18:46
@chbruyand chbruyand merged commit 66077f9 into PowerDNS:master Jan 18, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delay the Notifications
3 participants