New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: add a configurable delay for notifications #13649
auth: add a configurable delay for notifications #13649
Conversation
Pull Request Test Coverage Report for Build 7573561075
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I wonder if pdns_control notify
should be undelayed, but we can also wait and see what users think. So, approved.
If you feel there is any work left, I'll wait, but otherwise, please hit Ready for review (and you might as well just merge then). |
Oh, I just realised it doesn't have docs yet! |
4613530
to
49dc722
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, really approved now :)
49dc722
to
d3bbe4e
Compare
Short description
Adds a configurable
delay-notifications
parameter to delay notifications.Fix #12785
Checklist
I have: