-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] C++11 compability #1558
[HOLD] C++11 compability #1558
Conversation
Not before 3.4.0 |
Seems that clang has stricter set of rules and boost is not compatible?
|
The revision is useful, because people tend to run random snapshots and they never can remember where it came from or what version it was. DATE and TIME could probably be removed. |
Well, we need to figure out how to fix the clang compile first. I'm not in favour of removing those here. |
DATE and TIME can be useful to easily see if someone has a snapshot that should contain X Y or Z or something from before it was merged/created. Having them can give an indication. |
If you go c++11, may as well switch to std::shared_ptr. |
the c++11 support is still optional, so we would have to check for HAVE_CXX11 define and use it if present. Would fix this though, you're right . |
pdns already logs VERSION, DATE and TIME at startup, surely we don't need to do that for every backend? I'll do a separate PR to clean that up. |
On most systems backends are complied as modules. If you remove this how can you tell if the backend module version is identical to the installed pdns_server version? |
@mind04 Surely pdns doesn't support modules built against a different version than the one you're running, and you always install everything from the same build? Anyway, half of the modules already don't report the version, and a few others don't report date and time, so it's not a very reliable mechanism as it stands now. If you insist I can leave the version in if you use it, and add it to the modules that lack it. I think date and time should really go, since this changes your binaries every time you rebuild. I'll post a separate PR, let's continue there. |
AFAIK it will load them and then possibly crash. |
it depends alot on how incompatible they are. in many circumstances you can use the modules even if they are compiled against different version, provided they are not too different. |
c4fb831
to
d4d679f
Compare
d4d679f
to
f79d5cd
Compare
@ahupowerdns want to pick this up? |
Currently unmergeable; probably some duplication with @ahupowerdns' big merge. Want to fix this up? |
I don't think this is really needed anymore. |
Fixes C++11 incompabilities and turns on it whenever possible.