Better error message for unfound new slave domains

[pieterlexis]

Closes #2405

[Habbie]

That strcmp smells bad :)

[cmouse]

My eyes :(

[pieterlexis]

Could use another review

[cmouse]

LGTM. 👍

[zeha]

Doing the errno check that late is probably unsafe/unportable.

[cmouse]

Could you catch http://en.cppreference.com/w/cpp/io/ios_base/failure instead? It comes with error code. Or std::system_error, has code as well.

[pieterlexis]

The zoneparser now throws a std::system_error and as that is a subclass of std::exception all other catches still work.

[Habbie]

zoneparser-tng.cc: In member function ‘void ZoneParserTNG::stackFile(const string&)’:
zoneparser-tng.cc:59:5: error: ‘error_code’ is not a member of ‘std’
     std::error_code ec (errno,std::generic_category());
     ^
zoneparser-tng.cc:59:21: error: expected ‘;’ before ‘ec’
     std::error_code ec (errno,std::generic_category());
                     ^
zoneparser-tng.cc:60:11: error: ‘system_error’ is not a member of ‘std’
     throw std::system_error(ec, "Unable to open file '"+fname+"': "+stringerror());
           ^
zoneparser-tng.cc:60:29: error: ‘ec’ was not declared in this scope
     throw std::system_error(ec, "Unable to open file '"+fname+"': "+stringerror());
                             ^
make[3]: *** [zoneparser-tng.o] Error 1

[pieterlexis]

std::errorcode is c++2011, interesting that it fails on travis

[Habbie]

LGTM (pending figuring out why Travis is throwing a fit)

[nlyan]

Can't help with the build issue on travis, but I'd recommend deploying a function like this somewhere to avoid code bloat with system_error

namespace  { // or mark it static
template <typename Message> __attribute__ ((noinline, cold, noreturn)) 
void throw_errno (Message&& msg) {
    throw std::system_error (errno, std::system_category(), 
              std::forward<Message> (msg));
}
}

You can see what kind of codegen you get without it, even at -O2, here: http://goo.gl/Kzfcsw

[mind04]

Please note the small warning sign on the cplusplus.com page:

This page describes a feature introduced by the latest revision of the C++ standard (2011). Older compilers may not support it.

[rgacogne]

It seems to work by adding #include <system_error> to both modified files.

[cmouse]

Didn't the logger support printing DNSName w/o toString today?

[pieterlexis]

when #4062 is merged, ostreams support this properly