allow newDN to take a DNSName in; document missing methods #4300

Merged
merged 2 commits into from Aug 11, 2016

Projects

None yet

3 participants

@Habbie
Member
Habbie commented Aug 8, 2016

I expect this could also be done with boost::variant; in fact I'm not 100% sure I'm not overwriting the first definition here.

@zeha
Collaborator
zeha commented Aug 8, 2016

in fact I'm not 100% sure I'm not overwriting the first definition here.

sounds like you want a ("unit") test.

@Habbie Habbie changed the title from allow newDS to take a DNSName in to [wip?] allow newDS to take a DNSName in Aug 8, 2016
@Habbie
Member
Habbie commented Aug 8, 2016

Maybe this needs docs. Maybe it's obvious this should work - it was to me!

@rgacogne
Member
rgacogne commented Aug 9, 2016

I'm pretty sure the first definition is overwritten. Based on 1, it looks like the only option is using boost::variant.

@Habbie Habbie changed the title from [wip?] allow newDS to take a DNSName in to [broken] allow newDS to take a DNSName in Aug 9, 2016
@Habbie Habbie changed the title from [broken] allow newDS to take a DNSName in to [broken] allow newDN to take a DNSName in Aug 9, 2016
@Habbie Habbie changed the title from [broken] allow newDN to take a DNSName in to [allow newDS to take a DNSName in Aug 9, 2016
@Habbie Habbie changed the title from [allow newDS to take a DNSName in to allow newDS to take a DNSName in Aug 9, 2016
@Habbie
Member
Habbie commented Aug 9, 2016

Changed to use boost::variant.

@Habbie Habbie changed the title from allow newDS to take a DNSName in to allow newDN to take a DNSName in Aug 11, 2016
@Habbie Habbie changed the title from allow newDN to take a DNSName in to allow newDN to take a DNSName in; document missing methods Aug 11, 2016
@Habbie
Member
Habbie commented Aug 11, 2016

Ready for review.

@rgacogne
Member

LGTM

@Habbie Habbie merged commit dd70106 into PowerDNS:master Aug 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Habbie Habbie deleted the Habbie:luacopydnsname branch Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment