allow newDN to take a DNSName in; document missing methods #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sounds like you want a ("unit") test. |
Habbie
changed the title
|
Maybe this needs docs. Maybe it's obvious this should work - it was to me! |
|
I'm pretty sure the first definition is overwritten. Based on 1, it looks like the only option is using |
Habbie
changed the title
Habbie
changed the title
Habbie
changed the title
Habbie
changed the title
|
Changed to use boost::variant. |
Habbie
changed the title
Habbie
force-pushed
the
luacopydnsname
branch
2 times, most recently
from
652dc1d
to
973e488
Compare
Habbie
changed the title
|
Ready for review. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect this could also be done with
boost::variant; in fact I'm not 100% sure I'm not overwriting the first definition here.