Revamp label compression code which (+ some cleanups) speeds up large packet creation by ~40% #4373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…= inline. Reverse its comparison order.
…gh these live on the stack, we were going through needless motions.
…n of names within themselves. Output easier to interpret than that from test-dnsrecords.
…lloc. This commit has a bug with compression within records, and it will fail the tests we made for that too.
…now. Solves SOA-inter record compression bug. Still left to do: add check for names with more labels than we are prepared to handle. Plus handle that case.
…pecial way. Fixed now.
…ctor can't compress. Plus deal with that case.
| } | ||
| catch(std::bad_alloc& ba) { | ||
| if(l_verbose) | ||
| cout<<"Domain "<<name<<" too large to compress"<<endl; |
There was a problem hiding this comment.
If I'm not mistaken, name is not the culprit here, the message might be misleading.
|
Looks fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big change that comes with a number of new tests.
After:
'write big referral' 0.10 seconds: 67707.6 runs/s, 14.77 usec/run
Before:
'write big referral' 0.10 seconds: 42556.4 runs/s, 23.50 usec/run
A 37% improvement.
Impact on root-server performance:
Is in line with these numbers - we now have good service in 4 cores up to around 80kqps, trouble used to start a bit beyond 40kqps. This graph has 60% packet cacheability.