New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove d_place from DNSResourceRecord #4549

Merged
merged 7 commits into from Feb 23, 2017

Conversation

Projects
None yet
4 participants
@zeha
Collaborator

zeha commented Oct 7, 2016

Now that DNSResourceRecords are only supposed to be created by backends, they certainly have no say in the DNSPacket positioning.

The DNSResourceRecord(DNSRecord&) constructor is renamed to DNSResourceRecord::fromWire and records going into packets are only ever converted from DNSResourceRecord (backend type) -> DNSRecord (wire type). This makes it safe to remove d_place from DNSResourceRecord and default to ANSWER in DNSRecord.

Finally FindNS::lookup(..., UeberBackend) goes away. Master/Slave support now really requires backends filling out DomainInfo.backend in getUpdatedMasters, all in-tree backends do that AFAICT.

Also drops serialize.

@zeha zeha added the auth label Oct 7, 2016

@zeha zeha added this to the auth-4.1.0 milestone Oct 7, 2016

@zeha

This comment has been minimized.

Show comment
Hide comment
@zeha

zeha Oct 24, 2016

Collaborator

Rebased.

Collaborator

zeha commented Oct 24, 2016

Rebased.

zeha added some commits Oct 7, 2016

Remove d_place from DNSResourceRecord
Now that DNSResourceRecords are only supposed to be created by backends, they certainly have no say in the DNSPacket positioning.
Remove "place" from Lua axfrfilter
The slave code did not pay attention to d_place in the received
DNSResourceRecords anyway, so throwing away that info is alright.
@zeha

This comment has been minimized.

Show comment
Hide comment
@zeha

zeha Dec 8, 2016

Collaborator

Rebased.

Collaborator

zeha commented Dec 8, 2016

Rebased.

@pieterlexis

This comment has been minimized.

Show comment
Hide comment
@pieterlexis

pieterlexis Jan 10, 2017

Member

I feel this makes it all more clean. @mind04, any comments?

Member

pieterlexis commented Jan 10, 2017

I feel this makes it all more clean. @mind04, any comments?

@ahupowerdns ahupowerdns referenced this pull request Feb 23, 2017

Closed

Another take on #4549 - d_place removal #5082

0 of 7 tasks complete

@ahupowerdns ahupowerdns merged commit 56d692a into PowerDNS:master Feb 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zeha zeha deleted the zeha:dnsrr branch Feb 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment