dnsdist: Fix FD leak on TCP connection failure, handle TCP worker creation failure #4753

Merged
merged 2 commits into from Dec 12, 2016

Projects

None yet

1 participant

@rgacogne
Member
rgacogne commented Dec 9, 2016

Short description

dnsdist might have leaked the file descriptor corresponding to a TCP socket if the initial connect() call failed and triggered an exception.
It might also have exited in the unlikely event of a failure during the creation of a TCP worker thread.

Checklist

I have:

@rgacogne rgacogne added this to the dnsdist-1.1.0 milestone Dec 9, 2016
@rgacogne rgacogne merged commit 2cef051 into PowerDNS:master Dec 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-tcp-fixes branch Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment