Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Don't cache ServFail / Refused if the TTL is set to 0 #5037

Merged
merged 1 commit into from Feb 21, 2017

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Feb 15, 2017

Short description

If the TTL for ServFail / Refused responses is set to 0, we currently cache these responses for less than 1s, while it would be more logical to simply interpret a 0-TTL as "don't cache".

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests
@rgacogne rgacogne added the dnsdist label Feb 15, 2017
@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Feb 15, 2017
@pieterlexis pieterlexis merged commit ef1d357 into PowerDNS:master Feb 21, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-dont-cache-servfail branch Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.