Change from time_t to uint32_t for serial in calculateSOASerial #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgacogne
reviewed
Feb 22, 2017
| @@ -330,7 +330,7 @@ bool DNSBackend::getBeforeAndAfterNames(uint32_t id, const DNSName& zonename, co | |||
| * \param sd Information about the SOA record already available | |||
| * \param serial Output parameter. Only inspected when we return true | |||
| */ | |||
| bool DNSBackend::calculateSOASerial(const DNSName& domain, const SOAData& sd, time_t& serial) | |||
| bool DNSBackend::calculateSOASerial(const DNSName& domain, const SOAData& sd, uint32_t& serial) | |||
| { | |||
| // we do this by listing the domain and taking the maximum last modified timestamp | |||
|
|
|||
There was a problem hiding this comment.
If we do this, we should probably make newest a uint32_t too then, and perhaps DNSResourceRecord::last_modified as well?
There was a problem hiding this comment.
Good one, although last_modified could be bigger when it comes from the backend (after 2038) so we might need some magic here to truncate properly?
There was a problem hiding this comment.
Won't truncation be proper by default, just by merit of stuffing a bigger number into a smaller one?
|
This PR has conflicts. |
|
ping |
pieterlexis
force-pushed
the
issue-1010-calculateSOASerial-uint32_t
branch
2 times, most recently
from
5fea984
to
c4e7632
Compare
`time_t` can be bigger or be negative, which could lead to overflow/underflow issues. Closes PowerDNS#1010
pieterlexis
force-pushed
the
issue-1010-calculateSOASerial-uint32_t
branch
from
c4e7632
to
f101300
Compare
zeha
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
time_t can be bigger, which could lead to overflow/underflow issues.
Closes #1010
Checklist
I have: