Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make our zone parser adhere to RFC2308 wrt implicit TTLs and add test #5094

Merged
merged 5 commits into from
Mar 3, 2017

Conversation

ahupowerdns
Copy link
Contributor

@ahupowerdns ahupowerdns commented Feb 28, 2017

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@ahupowerdns
Copy link
Contributor Author

#3673 references this issue. Note that we need to check if we talk about this in the documentation and SHOUT about this in the release notes

@Habbie
Copy link
Member

Habbie commented Feb 28, 2017

Code and test look good! For release notes, we should just handle that in this PR already so we don't forget.

@rgacogne
Copy link
Member

rgacogne commented Mar 2, 2017

pySNMP-related failure in Travis, rebasing should fix that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants