dnsdist: Add expungeBySuffix function #5159
Conversation
pdns/dnsdist-cache.cc
Outdated
| const CacheValue& value = it->second; | ||
| uint16_t cqtype = 0; | ||
| uint16_t cqclass = 0; | ||
| DNSName cqname(value.value.c_str(), value.len, sizeof(dnsheader), false, &cqtype, &cqclass, nullptr); |
There was a problem hiding this comment.
The qname, qtype and qclass are stored in the cache entry, we don't need to parse them again. I just noticed DNSDistPacketCache::expungeByName() does the parsing too, which is awful, we should fix that!
Thinking about it a bit more, we should probably just add a boolean parameter to DNSDistPacketCache::expungeByName() and do an equal comparison or an isPartOf() one depending on the boolean value.
| """ | ||
| misses = 0 | ||
| ttl = 600 | ||
| name = 'expungebyname.cache.tests.powerdns.com.' |
There was a problem hiding this comment.
You are reusing the exact same qname than a previous test in the same suite (expungebyname.cache.tests.powerdns.com) so depending on the execution order it might already be cached and the expected miss below will fail. I'd advise using a different qname for each test to prevent this kind of issues.
| """ | ||
| misses = 0 | ||
| ttl = 600 | ||
| name = 'expungebynameandtype.cache.tests.powerdns.com.' |
There was a problem hiding this comment.
Same issue here, this name is used by another test of the same suite.
|
I think the last commit should fix all your points. |
|
Looks good, thank you! Would you mind squashing a bit before I merge? |
RobinGeuze
force-pushed
the
addExpungeBySuffix
branch
from
8237526
to
490dc58
Compare
|
All squashed :) |
Short description
Adds an expungeBySuffix function that allows removing all names matching a suffix from cache. Closes #5109
Checklist
I have: