Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notify slaves after dnsupdate was processed #5263

Merged
merged 1 commit into from
May 13, 2017
Merged

notify slaves after dnsupdate was processed #5263

merged 1 commit into from
May 13, 2017

Conversation

fobser
Copy link
Contributor

@fobser fobser commented Apr 23, 2017

Short description

After successfully processing a UPDATE message we are not notifying our slaves.

In case of records got changed by the UPDATE send out notifies. Do not send notifies if nothing changed.

This works for me[tm] but I'm not sure if it's correct as I'm not too familiar with the code.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the auth-4.1.0 milestone Apr 24, 2017
@Habbie Habbie mentioned this pull request May 3, 2017
Merged
6 tasks
@pieterlexis pieterlexis merged commit 84de374 into PowerDNS:master May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auth enhancement needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fobser @pieterlexis @rgacogne