rec: Don't always validate when DNSSEC is set to process #5557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix DNSSEC validation statistics.
pieterlexis
approved these changes
Aug 10, 2017
rgacogne
added a commit
to rgacogne/pdns
that referenced
this pull request
Aug 10, 2017
…odes changed in PowerDNS#5557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Since the DNSSEC refactoring, the distinction between DNSSEC processing and validation was buggy, leading to DNSSEC validation being performed even when the
dnssecparameter was set toprocessorprocess-no-validate.Also fix DNSSEC validation statistics not being updated (they were updated in a function that is not being used anymore).
Checklist
I have: