auth api: return new serial in header after PATCH #5696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For zone PATCH requests, this adds a new `X-PDNS-Zone-Serial` response header with the new zone serial. Ideally this would be returned in a response JSON object, but this API currently return 204 No Content and I did not want to break any clients that might rely on this.
This adds the old serial as X-PDNS-Old-Serial and renames the header of the new one to match. The old serial is useful to verify that no other PATCH happened in the meantime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For zone PATCH requests, this adds new
X-PDNS-Old-SerialandX-PDNS-New-Serialresponseheaders with the zone serials before and after the changes.
Ideally this would be returned in a response JSON object, but this API
currently return 204 No Content and I did not want to break any clients
that might rely on this.
Short description
Checklist
I have: