New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth api: return new serial in header after PATCH #5696

Merged
merged 2 commits into from Sep 15, 2017

Conversation

Projects
None yet
2 participants
@wojas
Member

wojas commented Sep 15, 2017

For zone PATCH requests, this adds new X-PDNS-Old-Serial and X-PDNS-New-Serial response
headers with the zone serials before and after the changes.

Ideally this would be returned in a response JSON object, but this API
currently return 204 No Content and I did not want to break any clients
that might rely on this.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

wojas added some commits Sep 15, 2017

auth api: return new serial in header after PATCH
For zone PATCH requests, this adds a new `X-PDNS-Zone-Serial` response
header with the new zone serial.

Ideally this would be returned in a response JSON object, but this API
currently return 204 No Content and I did not want to break any clients
that might rely on this.
auth api: also return old serial from PATCH
This adds the old serial as X-PDNS-Old-Serial and renames the header of
the new one to match.

The old serial is useful to verify that no other PATCH happened in the
meantime.

@Habbie Habbie merged commit 24249de into PowerDNS:master Sep 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment