New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Correctly purge entries from the caches after a transfer #5766

Merged
merged 2 commits into from Oct 6, 2017

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Oct 5, 2017

Short description

Since the QC/PC split up, we only removed entries for the AXFR'd domain from the packet cache, not the query cache.
We also did not remove entries in case of IXFR. We might want to backport that second part to 4.0.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

rgacogne added some commits Oct 5, 2017

auth: Purge entries from the query cache on an incoming AXFR
Since the QC/PC split up, we only removed entries for the AXFR'd
domain from the packet cache, not the query cache.

@rgacogne rgacogne added this to the auth-4.1.0 milestone Oct 5, 2017

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Oct 5, 2017

Member

This fixes my inconsistency issues.

Member

Habbie commented Oct 5, 2017

This fixes my inconsistency issues.

@Habbie Habbie merged commit 02384ba into PowerDNS:master Oct 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:auth-purge-query-cache-on-axfr branch Oct 6, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment