Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--trace logging with more details about trust anchors, plus ttl of auth data #5876

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

ahupowerdns
Copy link
Contributor

Print more details of trust anchors. In addition, the --trace output that mentions if data from authoritative servers gets accepted now also prints the TTL and clarifies the 'place' number previously printed.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

…th data

Print more details of trust anchors. In addition, the --trace output that mentions if data from authoritative servers gets accepted now also prints the TTL and clarifies the 'place' number previously printed.
@pieterlexis
Copy link
Contributor

Maybe we should have a static vector for the names of the places (like vState and vStates) so we can show an actual name?

.... <<DNSPacketSections[rec.d_place]<<....

@ahupowerdns
Copy link
Contributor Author

I'm actually hoping for a slightly more generic solution. I know there are classes out there that create fast and simple mapping between enums and names. We have this issue for QType, RCode, validation states, record places, opcodes etc. https://stackoverflow.com/questions/28828957/enum-to-string-in-modern-c11-c14-and-future-c17-c20 has some discussion.

@pieterlexis
Copy link
Contributor

alright, let's make that an item for the 4.2 or 4.3 timeframe

@pieterlexis pieterlexis merged commit 35d2730 into PowerDNS:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants