New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Don't add non-IN records to the cache #6082

Merged
merged 2 commits into from Dec 11, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Dec 11, 2017

Short description

While processing records sent by an authoritative server, some of them could have been added to the cache even though they have a different class than IN. We should simply skip these records.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

rgacogne added some commits Nov 29, 2017

@rgacogne rgacogne added this to the rec-4.0.x milestone Dec 11, 2017

@aerique aerique merged commit fdd1fca into PowerDNS:rel/rec-4.0.x Dec 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec40-skip-cache-not-in branch Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment