Remove `theLog` and `theL` and replace this with a global g_log

[pieterlexis]

Short description

Should close #6357 and should prevent issues in the future.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled and tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[zeha]

❤️ ... but: theLog is the same length as theL(), except it's still a #define...

I'd suggest:

• kill theL altogether (needs .setName in receiver.cc, similar to what is done in pdns_recursor.cc)
• rename/move the static Logger l instance to s_log in global scope, and use that everywhere

That also gets rid of the if(!pname.empty()) check that is done on every L/theL() usage.

[rgacogne]

Looks good, a couple remarks.

[rgacogne]

I'm pretty sure all the #undef s_log can go since s_log is unlikely to collide with boost::multi_index in the same way L did.

[pieterlexis]

Ah yes, I caught some of them already, I'll search some some.

[rgacogne]

So, hum, why s_log? This variable is not static so perhaps g_log would make more sense?

[pieterlexis]

oh, indeed... This is me sucking at C++ because the static keyword gave all kinds of issues.. I'll se eif I can fit it with a fresh brain

[zeha]

right, i incorrectly suggested s_..., sorry!

[pieterlexis]

rebased to fix conflists, we should get this merged soon :)

[zeha]

pdns_recursor.cc: In function ‘int serviceMain(int, char**)’:
pdns_recursor.cc:3236:5: error: ‘L’ was not declared in this scope
     L<<Logger::Error<<"Unable to launch, udp-source-port-min is not a valid port number"<<endl;
     ^
pdns_recursor.cc:3242:5: error: ‘L’ was not declared in this scope
     L<<Logger::Error<<"Unable to launch, udp-source-port-max is not a valid port number or is smaller than udp-source-port-min"<<endl;
     ^
pdns_recursor.cc:3252:7: error: ‘L’ was not declared in this scope
       L<<Logger::Error<<"Unable to launch, udp-source-port-avoid contains an invalid port number: "<<part<<endl;
       ^

[zeha]

probably introduced by the rebase

[pieterlexis]

probably introduced by the rebase

Ugh, I did search for theL when rebasing :), not L. Will fix

[zeha]

Auth test failure looks unrelated. Merge sooner than later? :)

[pieterlexis]

rebased one more time, let's hope travis'll be green :)

[ahkok]

The zeromq backend module is still broken in the auth version 4.1.5 in the same way. (Boost 1.68)

[Habbie]

@ahkok you have replied to a merged pull request; like on a closed ticket, these comments often go unnoticed and will definitely be forgotten. Please report your problem as a comment on a relevant open ticket, or file a new ticket.