Remove `theLog` and `theL` and replace this with a global g_log #6358
Conversation
I'd suggest:
That also gets rid of the |
d4157d8
to
1349a51
Looks good, a couple remarks. |
@@ -30,7 +30,7 @@ | |||
#include <iostream> | |||
#include "dnsrecords.hh" | |||
#include <boost/utility.hpp> | |||
#undef L | |||
#undef s_log |
rgacogne
Mar 22, 2018
Member
I'm pretty sure all the #undef s_log
can go since s_log
is unlikely to collide with boost::multi_index
in the same way L
did.
I'm pretty sure all the #undef s_log
can go since s_log
is unlikely to collide with boost::multi_index
in the same way L
did.
pieterlexis
Mar 22, 2018
Author
Member
Ah yes, I caught some of them already, I'll search some some.
Ah yes, I caught some of them already, I'll search some some.
@@ -116,7 +116,7 @@ private: | |||
static pthread_key_t s_loggerKey; | |||
}; | |||
|
|||
extern Logger &theL(const string &pname=""); | |||
extern Logger s_log; |
rgacogne
Mar 22, 2018
Member
So, hum, why s_log
? This variable is not static so perhaps g_log
would make more sense?
So, hum, why s_log
? This variable is not static so perhaps g_log
would make more sense?
pieterlexis
Mar 22, 2018
Author
Member
oh, indeed... This is me sucking at C++ because the static
keyword gave all kinds of issues.. I'll se eif I can fit it with a fresh brain
oh, indeed... This is me sucking at C++ because the static
keyword gave all kinds of issues.. I'll se eif I can fit it with a fresh brain
zeha
Mar 22, 2018
Collaborator
right, i incorrectly suggested s_..., sorry!
right, i incorrectly suggested s_..., sorry!
e715532
to
481227b
rebased to fix conflists, we should get this merged soon :) |
|
probably introduced by the rebase |
Ugh, I did search for |
b30572d
to
14cdea4
Auth test failure looks unrelated. Merge sooner than later? :) |
rebased one more time, let's hope travis'll be green :) |
The zeromq backend module is still broken in the |
@ahkok you have replied to a merged pull request; like on a closed ticket, these comments often go unnoticed and will definitely be forgotten. Please report your problem as a comment on a relevant open ticket, or file a new ticket. |
Short description
Should close #6357 and should prevent issues in the future.
Checklist
I have: