-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name threads in the programs #6997
Conversation
Reading the diff, I think a |
pdns/auth-carbon.cc
Outdated
@@ -34,6 +34,11 @@ | |||
void* carbonDumpThread(void*) | |||
try | |||
{ | |||
string threadName = "pdns/carbonDump"; | |||
auto retval = pthread_setname_np(pthread_self(), const_cast<char*>(threadName.c_str())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By curiosity, why do you remove constness of the name
argument everywhere ?
Note that the |
Note that on BSDs, the function has a different signature:
|
Actually that's the Darwin signature.. the BSDs have at least two other signatures. @pieterlexis has it under control! |
a1efda8
to
f4703d4
Compare
Short description
This PR adds names to our progam's threads. These show up in
ps -eT
and in certainhtop
configuration. They might help users (and us) to figure out where the bottleneck in an application exists.Closes #6974
Tested on
Checklist
I have: