New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure --enable-pdns-option --with-third-party-module #7026

Merged
merged 6 commits into from Nov 29, 2018

Conversation

Projects
None yet
5 participants
@jsoref
Copy link
Contributor

jsoref commented Oct 5, 2018

Short description

https://github.com/PowerDNS/pdns/wiki/Yak-list

another yak I have with configure is our inconsistent use of --enable-X and --with-X
--enable are our programs's options and --with-X should be external deps

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@jsoref jsoref force-pushed the jsoref:configure-enable-with branch 3 times, most recently from 6d908d2 to b46c839 Oct 5, 2018

@Habbie Habbie requested a review from pieterlexis Oct 9, 2018

@jsoref jsoref force-pushed the jsoref:configure-enable-with branch from b46c839 to ff562e5 Oct 19, 2018

@pieterlexis
Copy link
Member

pieterlexis left a comment

I like it, I'll ask for a second opion in case I missed something

@pieterlexis pieterlexis requested a review from rgacogne Oct 26, 2018

@jsoref jsoref force-pushed the jsoref:configure-enable-with branch from ff562e5 to c91964e Oct 26, 2018

@rgacogne
Copy link
Member

rgacogne left a comment

While I see nothing technically wrong with this PR (and thanks a lot for the work), every packager is going to hate us for this, especially if we change this on a minor version.

@rgacogne

This comment has been minimized.

Copy link
Member

rgacogne commented Nov 2, 2018

PR is conflicted though :-/

@jsoref jsoref force-pushed the jsoref:configure-enable-with branch from c91964e to 3bbbeb1 Nov 2, 2018

@jsoref

This comment has been minimized.

Copy link
Contributor

jsoref commented Nov 2, 2018

@rgacogne: with some additional effort, we could probably support the old flag names... I don't remember the syntax.

@rubenk

This comment has been minimized.

Copy link
Contributor

rubenk commented Nov 28, 2018

I think this is long overdue, thanks. As a downstream packager I don't mind changing some things in spec files.

@Habbie Habbie added this to the auth-4.2.0-alpha1 milestone Nov 29, 2018

@Habbie Habbie merged commit 141e964 into PowerDNS:master Nov 29, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsoref jsoref deleted the jsoref:configure-enable-with branch Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment